Hi Ihor and everyone,
Earlier today I pushed commit 397c198a4 to main:
"org-colview: Fix multi-digit completed cookies in "X/" summary"
While working on recursive checkbox summaries, I stumbled upon a bug
where `org-columns--summary-checkbox-count' failed to recognize
completed cookies with 10 or more items (e.g. "[10/10]"), treating them
as incomplete.
Looking into the git history, it turns out this regex limitation
(\[\([1-9]\)/\1\] -> (any "1-9")) was introduced back in May 2017
(commit 39b3f45a7, Org 9.0.8) and has been present in every stable
release from Emacs 26.1 through Emacs 31.1 without being noticed.
I was genuinely surprised to see that this bug managed to stay hidden
for over 9 years -- sometimes it really feels like I'm the only person
actively using org-columns! :)
Minimal reproducer:
(should
(equal
"[1/2]"
(org-test-with-temp-text
"* H
** S1
:PROPERTIES:
:A: [10/10]
:END:
** S2
:PROPERTIES:
:A: [ ]
:END:"
(let ((org-columns-default-format "%A{X/}")) (org-columns))
(get-char-property (point) 'org-columns-value-modified))))
On the current bugfix branch (Org 9.8.10) this test still returns "[0/2]".
Since the fix was pushed directly to main, should commit 397c198a4 be
cherry-picked onto the bugfix branch as well, so that it lands in the
upcoming 9.8.x bugfix release?
Best,
--
Slawomir Grochowski
