"Alberti, Andrea" <[email protected]> writes:

> I would like to submit a small patch (see attachment) for org-id that
> addresses two related issues with UUID generation.
>
> The `uuidgen' program shipped with macOS produces uppercase UUIDs,
> while uuidgen on Linux produces lowercase ones.  Users who edit the
> same notes from both systems end up with inconsistently cased IDs.
> The patch downcases the output of org-id-uuid-program.
>
> It also changes the default of org-id-uuid-program to nil, so Org uses
> its internal generator instead of spawning an external process for
> every new ID.  When the built-in uuid.el (a candidate for Emacs 32) is
> available, `org-id-uuid' uses `uuid-v4'; otherwise it falls back to the
> existing implementation.
>
> So, switching to the internal generator directly buys us:
>
> - Consistency at the root across any machine; no need for special
>   downcasing since its output is already lowercase.
> - A considerable speed-up that can be relevant when several operations
>   are batched. On my machine, `uuid-v4' is roughly 500 times faster
>   than calling `uuidgen'.
>
> I have a copyright assignment with the FSF.

Thanks!
Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=63022c5a0
I also added you to the contributor list.
https://git.sr.ht/~bzg/worg/commit/0c76643a

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to