I'm sure Ihor wouldn't mind me taking over this review. Thank you very much for taking a look at this! It looks good and is almost ready. I just have some very minor nits I thought I'd bring up.
Paul Bryan <[email protected]> writes: > Attached is a patch to fix this. It's essentially just the patch from > No Wayman. I've added the reported by link. Not sure how if it should > also be credited somehow. It's only a very little thing though. When committing it add the argument "--author="Nicholas Vollmer <[email protected]>"" to set the author correctly. I grabbed the value from one of the earlier patches. If you've modified it enough to want your own name on it you can always add "Co-authored-by:". >>>> Ihor Radchenko <[email protected]> writes: >>>>> >>>>> I think we can make separator a variable (not a custom option). >>>>> This way, if someone absolutely wants to change it, they could. > +(defconst org-tag-crm-separator "[ \t]*[:,][ \t]*" > + "Regexp used to determine `crm-separator' when reading multiple tags.") > + A modifiable variable would mean defvar, not defconst. > From c8d41be0b18da80cd53437061af3f2a3da766329 Mon Sep 17 00:00:00 2001 > From: Paul Bryan <[email protected]> > Date: Tue, 13 Oct 2026 21:50:45 +1100 > Subject: [PATCH] org.el, org-capture.el: Introduce variable for completing > read separator reg when reading tags. "separator reg"? > * lisp/org.el org-tag-crm-separator: Introduce variable for regex > determining completing read separator when reading tags. Put the variable in parenthesis like "(org-tag-crm-separator)". > Separator now includes commas "," and colons ":". Separator has always included colons ":" :) > Reported by: "No Wayman" <[email protected]> Use "Reported-by". This is how git commit meta-data stuff works I think. I've never looked into what it actually does but I think you need to write them out exactly. Although if you change the author of the commit you don't need a "Reported-by" :) Thanks for helping us with this older report! Do let me know if you ever need any help with anything at all :)
