Hi, it seems that the following patch still didn't appear in the official repo. Shall I resend it with the commit message according to http://orgmode.org/worg/org-contribute.html#sec-5, especially with TINYCHANGE?
Thanks, Michal On Fri, 13 May 2011, Carsten Dominik wrote: > Patch 803 (http://patchwork.newartisans.com/patch/803/) is now "Accepted". > > Maintainer comment: none > > This relates to the following submission: > > http://mid.gmane.org/%3C1305189019-23615-1-git-send-email-sojka%40os.inf.tu-dresden.de%3E > > Here is the original message containing the patch: > > > Content-Type: text/plain; charset="utf-8" > > MIME-Version: 1.0 > > Content-Transfer-Encoding: 7bit > > Subject: [O] icalendar: Make alarm duration RFC5545 compliant > > Date: Thu, 12 May 2011 13:30:19 -0000 > > From: Michal Sojka <so...@os.inf.tu-dresden.de> > > X-Patchwork-Id: 803 > > Message-Id: <1305189019-23615-1-git-send-email-so...@os.inf.tu-dresden.de> > > To: Eric S Fraga <e.fr...@ucl.ac.uk>, > > emacs-orgmode@gnu.org > > Cc: Michal Sojka <so...@os.inf.tu-dresden.de> > > > > The format of alarm trigger was incorrect because "T" letter from > > dur-time element was missing (see > > http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some > > software (such as KOrganizer) to not interpret the alarms correctly. > > > > --- > > lisp/org-icalendar.el | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el > > index c4b1f89..3632b5e 100644 > > --- a/lisp/org-icalendar.el > > +++ b/lisp/org-icalendar.el > > @@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line." > > (let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault)))) > > (if (and (> org-icalendar-alarm-time 0) > > (car t1) (nth 1 t1) (nth 2 t1)) > > - (setq alarm (format > > "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" > > summary org-icalendar-alarm-time)) > > + (setq alarm (format > > "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" > > summary org-icalendar-alarm-time)) > > (setq alarm "")) > > ) > > (if (string-match org-bracket-link-regexp summary) > >
