[O] [PATCH] Escape link path only if path contains space or non-ascii character

[David Maus]

Hi there,

Attached patch should take care of mistakenly double-escaped links as
reported by Jeff Horn in <http://article.gmane.org/gmane.emacs.orgmode/48731>.

This patch might break `org-open-at-point' for some users if the
target application does not deal with (possibly) unescaped URLs. The
alternative to the guesswork would require parsing und analyzing the
link and its components (path, query, fragment) and check for
characters that absolutely need escaping depeding on the link type.

Hopefully this solution is good enough.

Best,
  -- David

From ddb461326896825dce6fd58bfd9e4ea25a3a35ff Mon Sep 17 00:00:00 2001
From: David Maus <dm...@ictsoc.de>
Date: Sun, 18 Dec 2011 19:23:57 +0100
Subject: [PATCH] Escape link path only if path contains space or non-ascii 
character

* org.el (org-open-at-point): Escape link path for http:, https:,
ftp:, news:, and doi: links only if the path contains space or
non-ascii character.

This should take care of mistakenly double-escaped links as reported
by Jeff Horn in <http://article.gmane.org/gmane.emacs.orgmode/48731>.

We are just guessing here and push the responsibility for proper
escaping to the target application.
---
 lisp/org.el |   13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 8a1fbd3..1274f24 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9569,13 +9569,16 @@ application the system uses for this file type."
            (apply cmd (nreverse args1))))
 
         ((member type '("http" "https" "ftp" "news"))
-         (browse-url (concat type ":" (org-link-escape
-                                       path org-link-escape-chars-browser))))
+         (browse-url (concat type ":" (if (org-string-match-p "[[:nonascii:] 
]" path)
+                                          (org-link-escape
+                                           path org-link-escape-chars-browser)
+                                        path))))
 
         ((string= type "doi")
-         (browse-url (concat "http://dx.doi.org/";
-                              (org-link-escape
-                               path org-link-escape-chars-browser))))
+         (browse-url (concat "http://dx.doi.org/"; (if (org-string-match-p 
"[[:nonascii:] ]" path)
+                                                      (org-link-escape
+                                                       path 
org-link-escape-chars-browser)
+                                                    path))))
 
         ((member type '("message"))
          (browse-url (concat type ":" path)))
-- 
1.7.2.5

pgpe7Wxn4TYM0.pgp
Description: PGP signature