Hi Greg, Thank you for looking into my debut feature!
On Wed, Apr 17, 2013 at 12:22:14AM +0200, Daimrod wrote: > Michael Strey <mst...@strey.biz> writes: [...] > > It allows entries like in the following example without effecting > > org-contacts current functions. > > > > #+BEGIN_SRC org > > * Surname, Name > > :PROPERTIES: > > :EMAIL: mailto:te...@test.de; [[mailto:n...@test.de]] f...@bar.biz > > :PHONE: [[tel:+49 351 4129535]], +491766626196 [[+49 (351) 41295-35]] ^ should be :PHONE: [[tel:+49 351 4129535]], +491766626196 [[tel:+49 (351) 41295-35]] > > :END: > > #+END_SRC [...] > Thank you for your patch, though here are a few suggestions: > - It looks like `chomp' does the same thing the `org-trim' (in `org.el') > if so you should use it. Done. Thanks for the hint. > - You should use `org-link-display-format' instead of > `org-contacts-strip-link'. I don't think so. `org-link-display-format' returns the description of the link if there is one. My `org-contacts-strip-link' always returns the target. Using `org-link-display-format' would lead to wrong results with links like [[mailto:f...@bar.com][foo (at) bar (dot) com]] [[tel:+49 351 4129535][+49 (0)351 4129535]] > - You have done some unrelated changes (fix some typos, ...), could you > provide a separated patches for them? Oh =:-|, another struggle with Git. I'm still learning and will do my best. > Regarding `org-contacts-split-property', I haven't found anything about > multiple values within a node property in `org-element' and the syntax > description doesn't mention it, so you were right to roll your own. :) That wasn't me. This (disputable) feature was already there for the :EMAIL: proprerty. Actually, I don't like multiple values within a node property and would prefer a VCard-like syntax like #+BEGIN_SRC org *** Strey, Michael :PROPERTIES: :KIND: individual :ORG: STREY Consult :FN: Michael Strey :N: Strey;Michael;; :ADR;TYPE=home:;;my street;my city;federal state;post code;my country :EMAIL: mailto:st...@myprovider.de :EMAIL;PREF=1: mailto:m...@mycompany.biz :TEL;TYPE="fax,work":[[tel:0321 21104568]] :TEL;TYPE="fax,home":[[tel:0351 4129535]] :TEL;TYPE="voice,home":[[tel:0351 4129535]] :LANG: de :ICON: ~/GTD/Icons/icon-strey_michael.jpg :END: #+END_SRC > However, I think it would be better to store the separators in a > variable (like `org-contacts-property-values-separator') and maybe even > to use it by default instead of `split-string-default-separators' > because we use it more and because it's easy to forget. That was already hard-coded before in Feng's `org-contacts-vcard-format'. But yes, you are right. Since it is limited by some constraints we should make it an extra variable. > > > + (loop for email in (org-contacts-split-property email-list) > > ^^^^ > > + for gravatar = (gravatar-retrieve-synchronously > > (org-contacts-strip-link email)) This should be correctly and worked for me during my tests. Confusingly `email-list' is not a list but a string here. Regards -- Michael Strey http://www.strey.biz
