Hi Eric,
Eric Schulte wrote:
> "Sebastien Vauban" <wxhgmqzgw...@spammotel.com> writes:
>> Eric Schulte wrote:
>>> "Sebastien Vauban" <wxhgmqzgw...@spammotel.com> writes:
>>>> Eric Schulte wrote:
>>>>>> Extra question: tested with a sh block, both of the above do work, that
>>>>>> is
>>>>>> with strings or symbols. Which one is supposed to be better (that is,
>>>>>> will be
>>>>>> more portable with time), if there is one?
>>>>>
>>>>> Both will be maintained. The contribution of a test exercising both
>>>>> options could provide an extra guarantee of perseverance. This is also
>>>>> a good first step towards editing the code. :)
>>>>
>>>> Here's my trial to do so [...].
>>>> Does this correspond to what you're asking for?
>>>
>>> Close, could you prepare this as a patch against the current code base?
>>> That way I can simply apply it locally and more easily test it.
>
> See the above, could you prepare this as a patch so that I can more
> easily read/use/test it?
Here the patch you asked for.
Best regards,
Seb
>From aa7230ff485df5d9775429b53487aefcc7cd911d Mon Sep 17 00:00:00 2001
From: Sebastien Vauban <wxhgmqzgw...@spammotel.com>
Date: Thu, 25 Apr 2013 15:24:58 +0200
Subject: [PATCH] Test support of explicitly specified colnames
* test-ob.el (test-ob/specific-colnames): Add test checking that given column
names are well present in the output table.
---
testing/lisp/test-ob.el | 32 ++++++++++++++++++++++++++++++++
1 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/testing/lisp/test-ob.el b/testing/lisp/test-ob.el
index bbbfbc4..d51e183 100644
--- a/testing/lisp/test-ob.el
+++ b/testing/lisp/test-ob.el
@@ -1106,6 +1106,38 @@ Paragraph"
(widen)
(should (should (re-search-forward "^: 3" nil t)))))
+(ert-deftest test-ob/specific-colnames ()
+ "Test passing specific column names."
+ (should
+ (equal "#+name: input-table
+| id | var1 |
+|----+------|
+| 1 | bar |
+| 2 | baz |
+
+#+begin_src sh :var data=input-table :exports results :colnames '(Rev Author)
+echo \"$data\"
+#+end_src
+
+#+results:
+| Rev | Author |
+|-----+--------|
+| 1 | bar |
+| 2 | baz |
+
+"
+ (org-test-with-temp-text "#+name: input-table
+| id | var1 |
+|----+------|
+| 1 | bar |
+| 2 | baz |
+
+#+begin_src sh :var data=input-table :exports results :colnames '(Rev Author)
+echo \"$data\"
+#+end_src
+"
+ (org-babel-execute-src-block)
+ (buffer-string)))))
(provide 'test-ob)
--
1.7.9
--
Sebastien Vauban
