Love this patch! Much more pleasing to the eye.
Cheers, Viktor Max Mikhanosha wrote: > I had always disliked how if you miss a habit deadline and then go on > a several day streak, first day still show up red. Makes it hard to > visually see "green streaks" > > Following patch adds a new variable `org-habit-show-done-always-green' > to fix that. It defaults to off, if enough people like it we can > make it new default. > > To illustrate the difference in display, try to count number of two > day streaks in below screen-shots. > > Current display: > > http://i.imgur.com/HlyXE2o.png > > With new option: > > http://i.imgur.com/3ZmImkP.png > > Note that no information is lost, you can still figure out if streak > started after missing a deadline, by color of the previous day. > > Regards, > Max > > From 5c7f9b63b6021631b19b883760340a18024e6344 Mon Sep 17 00:00:00 2001 > From: Max Mikhanosha <m...@openchat.com> > Date: Mon, 6 May 2013 09:26:10 -0400 > Subject: [PATCH] Add option to always show DONE days as green on consistency > graph. It can be enabled by setting > `org-habit-show-done-alwyays-green' variable to t. > > * lisp/org-habit.el (org-habit-get-faces): Add show done days green option > --- > lisp/org-habit.el | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/lisp/org-habit.el b/lisp/org-habit.el > index 8465ba4..0899f45 100644 > --- a/lisp/org-habit.el > +++ b/lisp/org-habit.el > @@ -85,6 +85,12 @@ (defcustom org-habit-completed-glyph ?* > :version "24.1" > :type 'character) > > +(defcustom org-habit-show-done-always-green nil > + "If non-nil, a DONE day will always be green in consistency > +graph, even if it was done after deadline" > + :group 'org-habit > + :type 'boolean) > + > (defface org-habit-clear-face > '((((background light)) (:background "#8270f9")) > (((background dark)) (:background "blue"))) > @@ -272,8 +278,9 @@ (defun org-habit-get-faces (habit &optional now-days > scheduled-days donep) > (if donep > '(org-habit-ready-face . org-habit-ready-future-face) > '(org-habit-alert-face . org-habit-alert-future-face))) > - (t > - '(org-habit-overdue-face . org-habit-overdue-future-face))))) > + ((and org-habit-show-done-always-green donep) > + '(org-habit-ready-face . org-habit-ready-future-face)) > + (t '(org-habit-overdue-face . org-habit-overdue-future-face))))) > > (defun org-habit-build-graph (habit starting current ending) > "Build a graph for the given HABIT, from STARTING to ENDING. > -- > 1.7.11.rc0.100.g5498c5f > > >
