Viktor Rosenfeld <[email protected]> writes: Thanks for the patch. A small comment follows:
> + (let ((type (org-element-property :type ts)) > + (uid (format "TS%d-%s" (incf counter) uid))) > + (when (or (eq with-timestamps t) > + (and (eq with-timestamps 'active) > + (memq type '(active active-range))) > + (and (eq with-timestamps 'inactive) > + (memq type '(inactive 'inactive-range)))) > + (org-icalendar--vevent entry ts uid summary loc desc > cat)))) This is not correct since COUNTER is increased before we know if the VEVENT will be created. IOW, (let ((uid ...))) should be moved after the `when'. Regards, -- Nicolas Goaziou
