Achim Gratz <strom...@nexgo.de> writes:

> Nick Dokos writes:
>> I pushed the fix to master. Thanks to York and Tom for all the help.
>
> I'm not sure this fix is complete.  It seems that when someone would
> manually enter org-mode (say, in a scratch buffer) Emacs could return to
> an entirely different mode upon executing org-reset.
>
>> | 2 unexpected results:
>> |    FAILED  test-ob/catches-all-references
>
> This one is the bug I reported earlier today.
>
>> |    FAILED  test-org-element/link-parser
>
> This on the other hand bisects to your commit.  Plus, the above
> explanation is the reason for the test fail.  I've pushed a fix
> (f2483ec) that hopefully has no other side-effects not covered by tests.
>

OK, thanks for that. I was rushing this morning and did a pattern match
on the test name and decided it couldn't be me: famous last words. And
to add insult to injury, I didn't check on failures without the patch.
Oy,vey...

However, with your patch there is the opposite side of the coin: if you
have a buffer in a mode derived from org (as in York's case), then doing
C-c C-c on the options line will reset the mode to org, not to the
derived one, right?

Nick



Reply via email to