Bastien wrote: > Hi Ian, > > Please send me your public key so that I can give you access to the > org-mode and worg repositories. > > Ian Kelling <i...@iankelling.org> writes: > >> From 9191e4a364e251119cf8b7c72e41f6c0d09583f2 Mon Sep 17 00:00:00 2001 >> Message-ID: <87ha5aqa93....@treetowl.lan> >> MIME-Version: 1.0 >> Content-Type: text/plain >> >> *lisp/org.el: Advise commands which jump to the mark > > The formatting of the Changelog message not good. > > It should be > > * org.el: Advise commands which jump to the mark. > > See http://orgmode.org/worg/org-contribute.html and example in > the git logs. > >> +(eval-after-load "simple" >> + '(defadvice set-mark-command (after org-make-visible activate) >> + "Make the point visible with `org-show-context'." >> + (org-mark-jump-unhide))) >> >> +(eval-after-load "simple" >> + '(defadvice exchange-point-and-mark (after org-make-visible activate) >> + "Make the point visible with `org-show-context'." >> + (org-mark-jump-unhide))) > >> +(eval-after-load "simple" >> + '(defadvice pop-global-mark (after org-make-visible activate) >> + "Make the point visible with `org-show-context'." >> + (org-mark-jump-unhide))) > > This two ones are good, yes.
Even if the goal is desirable, I thought that we may not add defadvice in Emacs sources. (... a couple of minutes later ...) Well, Googling returns this : ╭──── http://www.gnu.org/software/emacs/manual/html_node/elisp/Advising-Functions.html │ │ Emacs's own source files should not put advice on functions in │ Emacs. There are currently a few exceptions to this convention, but we │ aim to correct them. ╰──── So, it seems this should be avoided as long as Org does go into Emacs. Best regards, Seb -- Sebastien Vauban
