Nicolas Goaziou <m...@nicolasgoaziou.fr> writes:

> I think core is fine for new languages, but you need to update file
> headers accordingly.

Will do.

> A few comments follow.

Thanks for your comments.  Updated.

> You don't use `org-babel-stan-cmdstan-directory' to store FILE, i.e.,
> FILE is saved in current directory, or any directory provided in its
> path, which doesn't necessarily match
> `org-babel-stan-cmdstan-directory'. Yet, make is called on
> `org-babel-stan-cmdstan-directory'.
>
> Is it intentional?

Yes.  The Makefile in the CmdStan directory can be used to compile any
*.stan file (regardless of whether it is in the CmdStan source
directory) into a model executable that's in the same directory as the
original *.stan file.

I'll wait a bit to see if any more comments come in and then install the
updated version in master, if that is OK with you.

Thanks.

--
Kyle

Reply via email to