> I think this fix is more correct. Does it give good results? I've already committed a similar fix (after Kim and Stefan agreed with it) but your patch nicely illustrates my earlier point about tabs: the line "record_buffer (buffer);" appears not to be indented but really it is (with a tab). Setting indent-tabs-mode to nil would presumably stop this apparent anomaly. I've reproduced it below without citation marks because this produces proper indentation.
-- Nick http://www.inet.net.nz/~nickrob *** buffer.c 22 Aug 2006 10:59:44 -0400 1.507 --- buffer.c 24 Aug 2006 10:35:16 -0400 *************** *** 1684,1692 **** char *err; if (EQ (buffer, Fwindow_buffer (selected_window))) ! /* Basically a NOP. Avoid signalling an error if the selected window ! is dedicated, or a minibuffer, ... */ ! return Fset_buffer (buffer); err = no_switch_window (selected_window); if (err) error (err); --- 1684,1699 ---- char *err; if (EQ (buffer, Fwindow_buffer (selected_window))) ! { ! /* Basically a NOP. Avoid signalling an error in the case where ! the selected window is dedicated, or a minibuffer. */ ! ! /* But do put this buffer at the front of the buffer list, ! unless that has been inhibited. */ ! if (NILP (norecord)) ! record_buffer (buffer); ! return Fset_buffer (buffer); ! } _______________________________________________ emacs-pretest-bug mailing list [email protected] http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
