> -----Original Message----- > From: Lennart Borgman (gmail) [mailto:[EMAIL PROTECTED] > Sent: Sunday, May 06, 2007 10:41 PM > To: Eli Zaretskii > Cc: Eivind Midtgård; emacs-pretest-bug@gnu.org > Subject: Re: Maximization doesn't work properly on Windows > Xp, Emacs 22.0.92.1 > > Eli Zaretskii wrote: > >> Date: Sun, 06 May 2007 21:19:53 +0200 > >> From: "Lennart Borgman (gmail)" <[EMAIL PROTECTED]> > >> Cc: emacs-pretest-bug@gnu.org > >> > >> The reason for the problem is that the Emacs window (frame) is not > >> really maximized on MS Windows. > > > > That's true, but I'm not sure it's relevant. Even if Emacs doesn't > > really maximize the frame, it does try to keep away of the parts of > > the screen taken by the task bar and the other standard decorations. > > That it doesn't always succeed means we have a subtle bug. > > > > To find and fix that bug, we need a reliable way of reproducing it. > > If Eivind or you can provide such a reliable recipe, we > will be on our > > way towards fixing the bug. > > I thought of that in the beginning, but I believe Windows is > beeing fooled by the way Emacs tries to make a semi-maximized > window. It may be hard to cure it. > > I think it is better to wait for an OK to really maximize the > window from Kim and others that are experts on the display > engine. The semi-maximized windows have other subtle problems too. > > And indeed there are thousands of users who have had the > possibilities to use the patch for really maximized windows, > but I have no idea how many of those that are using maximized > windows. It is hard to believe that no one has done it and > there are no bug reports. Eh, or was it one person who had > seen the same problem as I have seen? Not sure. (Of course it > does not mean more than an indication that there are no big > problems.)
Hi Lennart, Eli, I have tested this a little bit more, and found that it is perfectly reproducible: * Taskbar at the left (or right) of the screen, always visible. * Maximize Emacs. * Minimize Emacs. * Click on the Emacs icon on the taskbar - it restores to the screen width and then becomes obscured by the taskbar. Strange I've never tried this before. I tried it now with 22.0.50.1. It worked perfectly. I must confess that my 22.0.50.1 was downloaded bundled with EmacsW32, so maybe it's slightly different from your 22.0.50.1? There is another difference too: 22.0.50.1 covers the whole desktop except for the taskbar. 22.0.92.1 doesn't, there are a few spare desktop pixels at the bottom. I tried 23.0.0.1: It behaves like 22.0.92.1. I wonder if the problem is in x_make_frame_visible in w32term.c, because it explicitly assumes the taskbar is at the bottom. /* Adjust vertical window position in order to avoid being covered by a task bar placed at the bottom of the desktop. */ SystemParametersInfo(SPI_GETWORKAREA, 0, &workarea_rect, 0); GetWindowRect(FRAME_W32_WINDOW(f), &window_rect); if (window_rect.bottom > workarea_rect.bottom && window_rect.top > workarea_rect.top) f->top_pos = max (window_rect.top - window_rect.bottom + workarea_rect.bottom, workarea_rect.top); x_set_offset (f, f->left_pos, f->top_pos, 0); I have never been able to compile Emacs (msvc), so I can't verify it. Regards, Eivind _______________________________________________ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug