On Mon, 20 Jun 2011 02:37:10 +0900, "Stephen J. Turnbull" <step...@xemacs.org> wrote: > R. David Murray writes: > > > So, opinions: should I implement the heuristics, or should I refuse > > to guess and bail if from_addr and/or to_addrs is None and there are > > any Resent headers in the message? (Third alternative: continue to > > auto-detect it if there is only one set, as the current patch > > does.) > > The heuristics should be implemented as a separate function or method, > and a way to specify the function to call. My taste would be to > default the control variable/attribute to None, but if the use case > you're thinking about is sufficiently common or you want backward > compatibility, you could default it to your heuristics.
Hmm. That would be an API addition. Current the code is just buggy, in that it completely ignores Resent- headers, which is just wrong. So having a new API switch default to None would be fine, and my preference. Given what everyone has said, it sounds like for 3.2 I should fix the bug by implementing the stuff that is not a guess (Sender, and using Resent- if there is only *one* set of Resent- headers), and generate a ValueError if there is more than one copy of any of the Resent- headers. Then for 3.3 we could have a "guess please" knob...but I think I'm not going to take the time to implement it until we get an actual request for it. -- R. David Murray http://www.bitdance.com _______________________________________________ Email-SIG mailing list Email-SIG@python.org Your options: http://mail.python.org/mailman/options/email-sig/archive%40mail-archive.com
