Hi Gerald, On Mon, Aug 26, 2013 at 08:13:41AM +0200, Gerald Richter wrote: > I will take a closer look to it during the next few days, create a > new tar.gz to make sure nothing is missing and give you a feedback.
I just noticed there's a new Embperl 2.5.0 RC4 and checked how far it
comes with regards to the test suite.
There are still a bunch of hash randomisation issues. I've attached a
patch which fixes all of those I encountered so far by running the
test suite many dozen times. I would expect that you could apply this
patch to your code without changes.
Further I disabled all tests which just check more or less Perl
version specific error messages (i.e. includeerr{2,3}.htm) in our
package build. (But I think that should be solved differently
upstream, if it's an issue for you, too.)
This leaves so far two issues which look like real bugs:
#66 lists.htm fails occassionally and non-deterministically, but it
doesn't seem to be a hash randomisation issue. If it fails, it looks
like this:
#66 lists.htm...
Error in Line 54
Is: ></select></p><
Should: ><optionvalue="B"SELECTED>2</option><
Input: test/html/lists.htm
Output: test/tmp/out.htm
Compared to: test/cmp/lists.htm
Log: test/tmp/test.log
Testparameter:
query_info = sel=2&SEL1=B&SEL3=D&SEL4=cc
And if I check test/tmp/out.htm vs test/cmp/lists.htm, I see
<p><select name="D1" size="1">
<option value="A" >1</option>
</select></p>
but should see
<p><select name="D1" size="1">
<option value="A" >1</option>
<option value="B" SELECTED>2</option>
<option value="C" >3</option>
<option value="D" >4</option>
<option value="E" >5</option>
<option value="F" >6</option>
</select></p>
This does not look like a hash randomisation issue to me and hence may
be a real bug.
If #66 passes, the next one which fails (and always fails) is #147
exit.htm:
#147 exit.htm...
Error in Line 11
Is: After Exit
Should: <EOF>
Input: test/html/exit.htm
Output: test/tmp/out.htm
Compared to: test/cmp/exit.htm
Log: test/tmp/test.log
Testparameter:
cgi = 0
This looks like a real bug as "[- exit -]" seems to have no effect but
should have an effect.
Hope this helps.
Regards, Axel
--
,''`. | Axel Beckert <a...@debian.org>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
`- | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
Description: Fix hash randomisation issues in test suite Author: Axel Beckert <a...@debian.org> Forwarded: not-yet Index: libembperl-perl/test/cmp/escape.htm =================================================================== --- libembperl-perl.orig/test/cmp/escape.htm 2014-01-26 01:42:30.000000000 +0100 +++ libembperl-perl/test/cmp/escape.htm 2014-01-26 01:42:30.000000000 +0100 @@ -41,17 +41,17 @@ IMG: <img src="http://localhost/tests?id=abcdefghijklmnopqrstuvwxyz&text=This%20is%20a%20text%20%3F%20%26%20%2B%20-%20%2521"; name="%20foo"> FORM: <form action="http://localhost/tests?id=abcdefghijklmnopqrstuvwxyz&text=This%20is%20a%20text%20%3F%20%26%20%2B%20-%20%2521"; name="%20foo"> -Hash in A <a href="http://localhost/tests?A=1&B=2";> +^Hash in A <a href=\"http:\/\/localhost\/tests\?(A=1\&B=2|B=2\&A=1)"> Array in A <a href="http://localhost/tests?X=9&Y=8&Z=7";> -Hash in H <a href="http://localhost/tests?A=1&B=2";> +^Hash in H <a href=\"http:\/\/localhost\/tests\?(A=1\&B=2|B=2\&A=1)"> ^Array in H <a href=\"http\:\/\/localhost\/tests\?(X=9|Y=8|Z=7)\&(X=9|Y=8|Z=7)\&(X=9|Y=8|Z=7)\"> ^<a href=\"tst.html\?(par1=1|par2=2)&(par1=1|par2=2)\">1<\/a> -^<a href=\"tst.html\?(par1=1&par2=2|par2=2&par1=1)&par3=3\">2<\/a> -<a href="tst.html?par1=1&par2=2">3</a> -<a href="tst.html?par1=1&par2=2&par3=3">4</a> +^<a href=\"tst.html\?par([123])=\1\&par([123])=\2\&par([123])=\3\">2<\/a> +^<a href=\"tst.html\?(par1=1\&par2=2|par2=2\&par1=1)\">3</a> +^<a href=\"tst.html\?par([123])=\1\&par([123])=\2\&par([123])=\3\">4</a> Index: libembperl-perl/test/cmp/include.htm =================================================================== --- libembperl-perl.orig/test/cmp/include.htm 2014-01-26 01:42:30.000000000 +0100 +++ libembperl-perl/test/cmp/include.htm 2014-01-26 01:42:30.000000000 +0100 @@ -43,7 +43,7 @@ <P><table><tr><td>fdat1</td><td>text1</td></tr><tr><td>test1</td><td>value1</td></tr></table></P> <H1> 7b.) Presetup \%fdat</H1> -<P><table><tr><td>fdat2</td><td>text2</td></tr><tr><td>test2</td><td>value2</td></tr></table></P> +^<P><table>(<tr><td>fdat2</td><td>text2</td></tr><tr><td>test2</td><td>value2</td></tr>|<tr><td>test2</td><td>value2</td></tr><tr><td>fdat2</td><td>text2</td></tr>)</table></P> <H1> 7c.) Presetup \@ffld</H1> <P><table></table></P> @ffld = fdat3 test3 Index: libembperl-perl/test/cmp/hidden.htm =================================================================== --- libembperl-perl.orig/test/cmp/hidden.htm 2013-08-29 16:17:33.000000000 +0200 +++ libembperl-perl/test/cmp/hidden.htm 2014-01-26 01:46:45.000000000 +0100 @@ -9,10 +9,10 @@ <p> </p> a1<input type="hidden" name="feld1" value="Wert1"><input type="hidden" name="feld2" value="Wert2"><input type="hidden" name="feld3" value="Wert3"><input type="hidden" name="feld4" value="Wert4"> - a2<input type="hidden" name="feld1" value="Pfalz"><input type="hidden" name="feld2" value="Rhein"hessen"&Pfalz"> +^ a2(<input type=\"hidden\" name=\"feld1\" value=\"Pfalz\"><input type=\"hidden\" name=\"feld2\" value=\"Rhein\"hessen\"\&Pfalz\">|<input type=\"hidden\" name=\"feld2\" value=\"Rhein\"hessen\"\&Pfalz\"><input type=\"hidden\" name=\"feld1\" value=\"Pfalz\">) a3<input type="hidden" name="feld2" value="Rhein"hessen"&Pfalz"> a4<input type="hidden" name="feld2" value="Rhein"hessen"&Pfalz"> - a5<input type="hidden" name="feld1" value="Pfalz"><input type="hidden" name="feld2" value="Rhein"hessen"&Pfalz"> +^ a5(<input type=\"hidden\" name=\"feld1\" value=\"Pfalz\"><input type=\"hidden\" name=\"feld2\" value=\"Rhein\"hessen\"\&Pfalz\">|<input type=\"hidden\" name=\"feld2\" value=\"Rhein\"hessen\"\&Pfalz\"><input type=\"hidden\" name=\"feld1\" value=\"Pfalz\">) a6<input type="hidden" name="feld2" value="Rhein"hessen"&Pfalz"> a7<input type="hidden" name="feld2" value="Rhein"hessen"&Pfalz"> a8<input type="hidden" name="feld4" value="Wert4"><input type="hidden" name="feld3" value="Wert3"><input type="hidden" name="feld2" value="Wert2"><input type="hidden" name="feld1" value="Wert1">
signature.asc
Description: Digital signature
