I would recommend not to include this patch as-is.
I am concerned about it because it will not interact well with a second
source of control for feed override. However, if we *are* going to go
in this direction (since an integrator is well within his rights to
decide that there will only be a single source of control), then it
should be added uniformly for all similar items at the same time --
spindle override being the one that comes to mind first since it's in
the context.
While working in this area, I noticed enables should be added for the
'counts' method of controlling feed and spindle override, so that a
single mpg can be switched from one of those overrides to another
purpose by a switch.
Michał, in the future please submit patches on the emc-developers
mailing list, rather than direct to me in private e-mail.
Index: src/emc/usr_intf/halui.cc
===================================================================
RCS file: /cvs/emc2/src/emc/usr_intf/halui.cc,v
retrieving revision 1.64
diff -u -3 -r1.64 halui.cc
--- src/emc/usr_intf/halui.cc 2 Dec 2008 18:33:40 -0000 1.64
+++ src/emc/usr_intf/halui.cc 16 Dec 2008 21:53:07 -0000
@@ -295,6 +295,7 @@
hal_float_t *fo_value; //current Feed Override value
hal_bit_t *fo_increase; // pin for increasing the FO (+=scale)
hal_bit_t *fo_decrease; // pin for decreasing the FO (-=scale)
+ hal_float_t *fo_cmd; // pin for direct control the FO
hal_s32_t *so_counts; //pin for the Spindle Speed Override counting
hal_float_t *so_scale; //scale for the Spindle Speed Override counting
@@ -364,6 +365,7 @@
hal_float_t fo_scale; //scale for the Feed Override counting
hal_bit_t fo_increase; // pin for increasing the FO (+=scale)
hal_bit_t fo_decrease; // pin for decreasing the FO (-=scale)
+ hal_float_t fo_cmd; // pin for direct control the FO
hal_s32_t so_counts; //pin for the Spindle Speed Override counting
hal_float_t so_scale; //scale for the Spindle Speed Override counting
@@ -893,6 +895,8 @@
if (retval != HAL_SUCCESS) return retval;
retval = halui_export_pin_IN_bit(&(halui_data->fo_decrease),
"halui.feed-override.decrease");
if (retval != HAL_SUCCESS) return retval;
+ retval = halui_export_pin_IN_float(&(halui_data->fo_cmd),
"halui.feed-override.commanded");
+ if (retval != HAL_SUCCESS) return retval;
retval = halui_export_pin_IN_s32(&(halui_data->so_counts),
"halui.spindle-override.counts");
if (retval != HAL_SUCCESS) return retval;
@@ -1691,6 +1695,12 @@
old_halui_data.fo_counts = counts;
}
+ floatt = *halui_data->fo_cmd;
+ if(floatt != old_halui_data.fo_cmd) {
+ sendFeedOverride(floatt);
+ old_halui_data.fo_cmd = floatt;
+ }
+
//spindle-override stuff
counts = *halui_data->so_counts;
if(counts != old_halui_data.so_counts) {
------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you. Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Emc-developers mailing list
Emc-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/emc-developers
