Sebastian Kuzminsky wrote: >Jeff Epler wrote: > > >>On Wed, Oct 21, 2009 at 12:21:16AM -0600, Sebastian Kuzminsky wrote: >> >> >>>ef35c86acf71b1e5897e456d214a38e538cbd108 Fix homing in the hm2-servo config. >>> >>> >>I notice you added some comments like >>+# only my Y servo has an index >>and changes some of the inifile values around as well. I just wanted to >>make sure this was deliberate before I apply to 2.3. >> >> > >It *was* intentional, but maybe my intentions were wrong. What i >checked in is a configuration that i've verified on my test rig, It >Works For Me(tm), and it shows how stuff goes together, but it's not a >general-purpose drop-in config for anyone's milling machine. > >I put in comments like that one to help folks understand why the config >has the idiosyncrasies it does and hopefully help them customize it to >their machine. > >The hm2-servo config shows both indexed and non-indexed homing, which i >think is a good feature. > > Agreed.
>But i'd be happy to change it if this is not the proper way to do sample >configs. > > I think it might be better to have the comments be instructive, rather than anecdotal. Something like "This axis shows how to sset up 'home to index'", rather than "my machine is like this". - Steve ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
