On Wed, May 05, 2010 at 10:55:42AM +0100, Andy Pugh wrote: > On 5 May 2010 03:34, Sebastian Kuzminsky <[email protected]> wrote: > > > In general: there is some whitespace strangeness (tabs vs spaces), > > I guess I need to lmake my editor match the "style guide", I assume > the information is there.
There's really not a style guide, and we're not always consistent from file to file. The best advice I can give is * set your editor for a monospace font * set your editor to show a tab character as 8 spaces * set your editor to 4- or 8- space indents depending on the prevailing style in a particular file * set your editor to insert only spaces, or to insert tabs and/or spaces depending on the prevailing style in a particular file * view the "git diff" in the terminal or look in git gui or gitk to see whether things line up there. If not, back to the drawing board to fix up whitespace * for a new file, it's OK to run an automatic indentation tool before the first commit. For an existing file, it's almost never OK. We don't routinely use automatic indentation tools because they produce undesired noise in the revision history; often I want to know when some code was written, and find the log message associated with the change. If automatic indentation tools are used, they make the process of finding this information more difficult. > > and it's lacking documentation (in the hostmot2.9 man page), > > Does that go in the .patch too, or is there another submission path? Personally I'd put the documentation for the new functionality in the same commit that adds the functionality. Jeff ------------------------------------------------------------------------------ _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
