On 11/11/2010 07:21 PM, Andy Pugh wrote: > An updated and tested version of the 8i20 patch. >
Thanks for the patch, I've looked briefly over it. Some questions/feedback: Does this code drive the hostmot2 firmware module called "UART" in the regmap? Or something else not mentioned in the current regmap? A comment in hostmot2.h calls it "Smart Serial Interface". That's not a term-of-art that i'm familiar with, and it has the unfortunate acronym "SSI", which *is* a term-of-art meaning "Synchronous Serial Interface" (which the hostmot2 firmware supports). May I suggest the name "uart" as more clear, or some other name? Or at least some clarifying documentation or comments somewhere. The filenames of the 8i20 and 7i64 drivers are misleading. The "hm2_" filename prefix has so far been used to denote Anything I/O boards - boards that can run the hostmot2 firmware. We have hm2_7i43 and hm2_pci (for all the PCI AnyIO boards). The 8i20 and 7i64 are daughter boards that *talk* to AnyIO boards via RS 422, and it'd be nice if the filenames reflected that. Somehow. Please add a blurb to the manpage describing how the new subsystem works, some examples of hardware it works with. Also describe how to configure it (your additions to the config= modparam) and how to use the HAL interface it presents. Don't change the rtapi msg_level (around line 1080 of your changed hostmot2.c). (I think this was some debugging code that got accidentally left in.) The function called h2m_sserial_start() would be less surprising (to me at least) if it were called hm2_mumble_force_write(), like all the others. What's the difference between sserial.num_instances and sserial.num_modules? The ioport munging in hm2_sserial_parse_md() scares me. I haven't read all the code, but that's all that's stuck out so far. Thanks for your work on this! -- Sebastian Kuzminsky ------------------------------------------------------------------------------ Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
