From: [email protected]
To: [email protected]
Subject: RE: [Emc-developers] No hal pin LED PATCH for 2.5
Date: Thu, 12 Jan 2012 01:57:21 +0000
> -----Original Message-----
> From: Pavel Shramov <[email protected]>
> Date: Wed, 11 Jan 2012 17:35:00
> To: <[email protected]>
> Subject: Re: [Emc-developers] No hal pin LED PATCH for 2.5
>
> On Tue, Jan 10, 2012 at 08:05:46AM +0000, Chris Morley wrote:
> > This patch allows one to select 'HAL pin type' 0 (no pin) or 1 (regular
> > in
> > pin)
> > in the Glade editor - it defaults to 1 which is with the HAL pin.
> It's better to use boolean type so glade will show it as checkbox. Along with
> more
> obvious name (like without_hal_pin) it will be more easy to understand.
>
> > Ultimately I think we should allow a third option - an LED with an out
> > pin
> > that follows the
> > LED state - but this patch does not include this option.
> It's just a led with input pin. Is not it?
>
> Otherwise patch looks ok.
>
Sorry I sent this privately to Pavel by mistake..
The reason for an integer rather then bool is in the future to facilitate
setting the pin as an in or as an out.
Or I could add two bools on for 'without HAL' one for in or out pin.
Same reason for the name pintype rather then without HAL
I can see a use to having a HAL pin that follows an LED that is set
programically
rather then having to have a program set a HAL pin and an LED.
Chris M
------------------------------------------------------------------------------
RSA(R) Conference 2012
Mar 27 - Feb 2
Save $400 by Jan. 27
Register now!
http://p.sf.net/sfu/rsa-sfdev2dev2
_______________________________________________
Emc-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/emc-developers
