On Thu, 2012-02-09 at 19:10 +0100, Michael Haberler wrote: > I'd look at referring to an external package only if it is big, > changes a lot or something breaks; and in the case of the VFD modbus > library (really just two files) I think including them is sufficient
libmodbus 3 is completely revamped, such as "bits" instead of "coils", causing a renaming of functions and variables. Also the functions have been restructured. > I dont think its worth the extra dependency and seeing what has > changed - modbus looks like a stable thing to me > > what I'll eventually do is integrate the vfs11 driver and make sure > only one copy of modbus.c/h is included, it can share with gs2_vfd > which has a modbus.c 3 years older Yes, the different modus.c and .h's got me confused for a while. > > afaict HAL comps dont use it; classicladder has its own modbus driver Offhand this doesn't seem ideal. Centralizing libmodbus seems cleaner, but I don't know any better. -- Kirk Wallace http://www.wallacecompany.com/machine_shop/ http://www.wallacecompany.com/E45/index.html California, USA ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
