On 12/13/13 15:17 , Robert Ellenberg wrote: > On Fri, Dec 13, 2013 at 3:55 PM, Sebastian Kuzminsky <[email protected]>wrote: > >> On 12/13/13 13:36 , Robert Ellenberg wrote: >>> I'm preparing a beta version of the circular arc blend branch on my mirror, >>> so I'm curious where would be the best place to rebase onto (latest master >>> vs. a 2.5 branch). >> >> Your feature belongs on master, but please don't merge it until after >> we've made the 2.6 release branch. > > Understood. Are there any tests that should be run on the code pre-merge ? > My plan is to do everything in github first, so there's no surprises when > moving to the official repo.
There is a small test suite in the tests directory of the repo, which can be run by the runtests program. But i think we are lacking tests of the trajectory planner. You and Sam have found many problematic gcode programs that caused velocity or acceleration constraint violations, right? Maybe those could be used as a basis for new automated tests? We talked about the motion-tests branch a while back. I can imagine a new test that runs all the gcode programs it finds in a special subdirectory, while using the check_constraints.hal config (also in that branch) to estop the machine and fail the test if the program violates any constraints. I'm not sure what other kinds of automated tests would be useful for your planner work, but I'm glad that you're taking testing so seriously. -- Sebastian Kuzminsky ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
