On 2014-04-24 05:57, EBo wrote:
> OK. The changes were a LOT more invasive than I expected, but things mostly 
> look ok and I would like to have them checked.
>

I was afraid that it would be such a large extent.

> As a note, I decided for the moment to *not* try to clean up the references 
> that deal with stuff like (*((uint32_t*)time_buff + 4, ...) The issue is
> that these need to be properly set to the addresses, and in other places as 
> the values, and my head started spinning trying to keep it all straight.
> So, I decided to take a stab at it as a two stage process.
>
> Attached there should be 3 patch files. The first two deal with the 
> long->int32_t weirdness, and the third traps when setuid returns errors and I
> write out an error message instead of ignoring it...
>
> These take care of all warnings except one which concerns me:
>
> =================
> libnml/buffer/physmem.cc: In constructor 
> ‘PHYSMEM_HANDLE::PHYSMEM_HANDLE(uint32_t, int32_t, int32_t)’:
>
> libnml/buffer/physmem.cc:60:42: warning: cast to pointer from integer of 
> different size [-Wint-to-pointer-cast]
> =================
>
> ... but I have run out of steam for the moment and want to send these off for 
> testing. If someone else can take a poke at the following error and
> see if there is *some* way to clean it up I would be most grateful.
>
> Hope this helps, and it this keeps getting any more weird I'll create a 
> branch instead, but for now I wanna be lazy.

Yes, I can empathize your mood.
I will try to make some tests in the next days.
Thank you for your endurance.


>
> EBo --

matsche


-- 
"In der Wissenschaft siegt nie eine neue Theorie,
nur ihre Gegner sterben nach und nach"

Max Planck


------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Emc-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/emc-developers

Reply via email to