On Thu, Jul 31, 2014 at 09:19:51AM -0600, Sebastian Kuzminsky wrote: > If someone emails a short patch to the list (or directly to a > maintainer) and says "i release this under GPLv2+, please merge", then a > committer could 'git am --signoff' the patch, that makes sense.
When submitting a patch via mailing list, the author should use "git commit -s" and "git format-patch"; this will preserve the original author's signed-off-by. If she didn't, you can put your own Signed-Off-By, certifying what it says under paragraph (b) -- that someone else wrote it, but to the best of your knowledge it is under a compatible license. > What if someone mails a pull request instead, "please fetch this branch > from my repo and merge"? At that point would the committer have to > rewrite each commit message by hand to add the Signed-off-by tag? > Rebase doesn't have a 'sign-off' option... That'd get unwieldy for big > branches like Rob Ellenberg's new trajectory planner. As I initially envisioned it, all the commits in a long-lived branch, whether on git.l.o or otherwise, would have to have Signed-off-by in all the commits. This would be inconvenient, for example, when we wanted to merge JA. Another technically feasible option is to only check this for the first child side of a merge, so that if the history has o AAAAA Merge long-lived branch with S-O-B |\ o \ BBBBB Previous master branch commit ⋮ o CCCCC Commit on feature branch without S-O-B ⋮ ⋮ ⋮ o DDDDD Commit on feature branch without S-O-B ⋮/ o EEEEE the choices would be to verify S-O-B on commits A, C, …, D (my original thought) or just commit A (the alternate proposal that "fixes" long-lived branches that did not care about S-O-B). My unfinished script also right now looks for S-O-B by both the committer and author of each commit; it probably should instead be satisifed with either commiter or author. Or maybe just any S-O-B header at all? > Looks like to rsync(?) output crept into your patch... I put the diff into my e-mail in an odd way (by invoking 'wget -O-') and I may not have deleted all the debris. I'm pretty sure the files themselves are fine. Jeff ------------------------------------------------------------------------------ Infragistics Professional Build stunning WinForms apps today! Reboot your WinForms applications with our WinForms controls. Build a bridge from your legacy apps to the future. http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
