Changes made and tested, appears OK. I have forked your linuxcnc-mirror repo and hopefully created a valid pull request to this commit.
If this works it is a major step forward in my git-fu :) regards On 09/11/14 14:59, schoone...@btinternet.com wrote: > On 09/11/14 13:39, Jeff Epler wrote: >> Hello. >> >> Since you're working on github, it's better to submit a github pull >> request, which will persist on a list on github until it's dealt with. > I will have to look into that. The only repo on github seemed to be > well behind the master > and because I had not forked that, was not aware how to create a pull > request to the main repo. >> I did not test with your patch, but here are some items I thought of >> while looking at the patch. >> >> I see that extralib is applied when building kernel modules as a part of >> EXTRA_CFLAGS. This won't work to actually link a library in kernel >> space (you simply can't do that in any way), and when building for the >> new "uspace" userspace realtime I doubt this will do what is desired. >> If the option is specified for a scenario where it can't be used, it >> would be better if it were an explicit error. You can do this by >> calling the Error() function with an explanatory message. > The libs I was thinking of were statically linked ones of common functions > not dynamically linked libraries,but I have removed that bit > and generated an error if used with rt builds. >> The syntax accepts multiple "extralib" lines but only the first one is >> ever used. You can use " ".join(extralibs) to concatenate all the >> various extralibs declarations. > That is what comes of cut and pasting the nearest thing in appearance to > what you need:) > I was only ever thinking of one line and just needed a string rather > than array > Makes more sense however to allow several entries in one file, join now used > > Will come back when tested and I find how to create a pull request from > an external repo > > regards > > > ------------------------------------------------------------------------------ > _______________________________________________ > Emc-developers mailing list > Emc-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/emc-developers ------------------------------------------------------------------------------ _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
