Dear Sebastian, Thank you for continued support of our commits:)
We have added author: https://github.com/geris2/linuxcnc-mirror/commits/gm-driver-fix <https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2Fgeris2%2Flinuxcnc-mirror%2Fcommits%2Fgm-driver-fix&sa=D&sntz=1&usg=AFQjCNFe_-yQ3wsRMhZd-rpVqP5k6Lf8jw> I am not sure about LinuxCNC version policy. -As 2.7 support uspace, that commit probably belongs to 2.7. -License change was needed by a uspace function call, so that commit may also belong to 2.7. -The RS485 fix commit may be checked in to the branch, where any other fix is currently checked in. 2.6 or master, what do you think? Best Regards, Bence 2015-02-12 16:11 GMT+01:00 Sebastian Kuzminsky <s...@highlab.com>: > On 02/12/2015 05:43 AM, Bence Kovács wrote: > > Dear Sebastian, > > > > Much later than expected, but we could finaly finish gm6-PCI driver > > USPACE support, tests, and we made also some fixes (all togeather 3 > > commits): > > https://github.com/geris2/linuxcnc-mirror/tree/gm-fix > > Could you check in to git? > > Hi Bence, Gergő! > > I looked at your commits and the code looks good. I'd love to get these > fixes into linuxcnc. > > A couple of issues: > > All three of these commits currently say "Author: cnc > <cnc@cnc-desktop>", but linuxcnc dev policy requires[0] that the Author > be a real person with a real email address. > > 0: > > http://linuxcnc.org/docs/html/code/Contributing-to-LinuxCNC.html#_git_configuration > > All commits also need to have a Signed-off-By: field[1], which certifies > that the Author has the legal right to publish the source code under the > specified license. (This is a new requirement that we added since last > time you sent me a pull request.) > > 1: > > http://linuxcnc.org/docs/html/code/Contributing-to-LinuxCNC.html#_signed_off_by_policy > > > Ok, those mechanical issues aside, i have another question. > > The first commit (that fixes the rs485 zero-voltage thing) and the last > commit (that changes the license) should go into 2.6, right? > > And the middle commit (the one that adds uspace support) should go into > 2.7 obviously. > > > Thanks for your continued support of linuxcnc :-) > > > -- > Sebastian Kuzminsky > ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
