Chris, I am a very strong proponent of having the UIs live in separate repositories. It would keep the LCNC tree cleaner, keep dependencies to a minimum, make maintenance and development of the UIs more straight froward and would also allow the UI to have its own issue tracker, which I think would be an advantage.
One way to do it would be with a git sub-module. Once set up the only difference would be you'd have to clone linuxcnc with --recurse-submodules. But there are other, maybe better, options.. since QtVCP is basically a python package already, it would be straight forward to make it a proper package and put it on PyPi. The advantage of that is that it could be installed with pip install qtvcp and pip would take care of the python dependencies. As it stands you can't run Qtscreen without tracking down and installing several pip and debian packages anyway, so to some extent you loose the advantage of it being installed with LCNC, and it may not make sense to have those packages as dependencies for LCNC as not everybody would need them. Another thought, Qtscreen may need to be compiled at some point (recourse files mainly, but it might make sense to (optionally) compile the UIs too to speed loading). I have added a makefile to my QtPyVCP branch to do this. This could be done with the main LCNC makefile but this might get a little tricky if somebody uses a build bot install of LCNC but wants to design their own QtVCP UI. Probably the best option would be to have QtVCP check for source changes on start up and recompile if needed, but if it was a separate package we could just stay with the makefile approach. make && make install is pretty easy even for newbies ... Cheers, Kurt On Mon, Jul 2, 2018 at 5:43 AM, Gene Heskett <[email protected]> wrote: > On Monday 02 July 2018 01:58:27 Chris Morley wrote: > > > In the fairly near future I intend to add Qtvcp/Qtscreen to linuxcnc. > > > > This is a python/Qt based virtual control panel similar to gladevcp. > > > > > > I am wondering if keeping the project separate from linuxcnc by using > > a subtree or sub module is a good idea. > > > > I ask this question without knowing very much about this technique. > > > > > > The plus side that I think I see is qtvcp's git history doesn't > > pollute linuxcnc's, so I am not tempted to squash it all before adding > > it to linuxcnc. > > > > The negative side is more git commands (for me) to learn. > > > > > > Right now the branch qt5vcp_py2 is the most current and is squashed > > compared to the (almost current) branch qt5_vcp_cleanup for those > > wanting to see what i am talking of. > > > > Ideally I would update qt5_vcp_cleanup, rename it and add it as a > > subtree - thus keeping all my git history, without adding 150+ commits > > to linuxcnc. > > > > > > Of course currently qtvcp is not a completely separate project - it > > uses linuxcnc's makefile system and this branch modifies linuxcnc > > files that qtvcp uses (such as hal_glib) - maybe this is a problem. > > > > > > Looking for opinions of the idea to begin with. > > > > > As a user, anything that extends what pyvcp can do, by doing more with > the screen real estate it uses (a major limitation of pyvcp) and will be > stable in the face of underlying system updates, which pyvcp seems to do > well and gladevcp hasn't, dying with every gtk update, will be a welcome > addition to linuxcnc. So I'll pre-thank you for your efforts Chris. > > And I look forward to trying it out. Thank you. > > > Thanks > > > > Chris M > > ---------------------------------------------------------------------- > >-------- Check out the vibrant tech community on one of the world's > > most engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > _______________________________________________ > > Emc-developers mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/emc-developers > > > > -- > Cheers, Gene Heskett > -- > "There are four boxes to be used in defense of liberty: > soap, ballot, jury, and ammo. Please use in that order." > -Ed Howdershelt (Author) > Genes Web page <http://geneslinuxbox.net:6309/gene> > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Emc-developers mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/emc-developers > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
