Gladevcp requires window1 mostly for embedability.
I believe the embed code assumes window1.
window1 is (was?) the default name for a window in glade.
Also the docs say window1 but that could be easily changed.
I like your change.
It may be possible to use top_level as a general term instead.
________________________________
From: Nicklas SB Karlsson <n...@nksb.eu>
Sent: March 27, 2022 1:55 PM
To: emc-developers@lists.sourceforge.net <emc-developers@lists.sourceforge.net>
Subject: [Emc-developers] GTK3 documentation bug?
Trying gtk3 with glade did not work first time. Reading traceback,
looking at the source code there error happened and insert a probe to
print object properties it seemed object did not contain the expected
property or properties. Looking again I could see in source code object
of named "window1" was expected. Setting ID in top level window to
"window1" and it worked.
It could of course be argued documentation should be read to so that
user know how it should be used but printing an a proper error message
ought to be a better and more common solution to this problem.
In file src/hal/user_comps/gladevcp.py At row 204 below:
window = builder.get_object("window1")
I inserted three rows to check and print a message and after required
compilation checked it seems to work. Below:
window = builder.get_object("window1")
if not window:
print("Did not find object with ID \"window1\" in glade file.
Expecting a window? at top level? with this name")
sys.exit(0)
For me it seems a better solution would be to generate the exception
inside the builder as soon as error is detected but this also work. Not
sure if object must be a window and on top level.
Suggest this change or adding the check inside the builder is done in
the source code? Or any objections? I should make a patch to make it happen?
Anyone know if expected object must be at top level? Must be a window?
Nicklas SB Karlsson
_______________________________________________
Emc-developers mailing list
Emc-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/emc-developers
_______________________________________________
Emc-developers mailing list
Emc-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/emc-developers
