On 11/29/24 19:30, andy pugh wrote:
Several cases of wrong argument to snprintf were detected by the
compiler and gave me a warning.
I wonder if these issues exist in the main CL release (CL is a
project that we forked, I think) This seems to be it?
https://github.com/MaVaTi56/classicladder
They use sprintf(), which got "fixed" in linuxcnc, but obiously fixed
incorrectly.
The uninitialized cairo_t * is in the original.
The fgets problem is also in the original, but many instances have been
changed with another function. How this affects the code is unknown.
The problematic write() is also in the original.
Anyway, these should be fixed as they are clearly problematic coding
that can lead to errors and serious problems. Is there a sync from their
repo into linuxcnc documented as a procedure? If so, it should be fixed
in upstream. If not, then the linuxcnc version will become divergent.
--
Greetings Bertho
(disclaimers are disclaimed)
_______________________________________________
Emc-developers mailing list
Emc-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/emc-developers
