It was a PR. I understand it's annoying for code to be broken and merge fixing conflicts. If your code went in it probably would have broken my code. My pr has been available to look at and comment on for about a year. I was in contact with the one collaborator that was interested in the code. I told him I was going to push.
Whether I did it by pushing the merge button or pushed directly would not have changed what happened nor would be out of the ordinary. The code I was working on I'm pretty familiar with. Having to wait for others to approve has never been formally agreed to. Gladevcp was a project I started and worked on for many years. Gmoccapy started off as a Gscreen based project, Norbert and I did much work together on Gladevcp and Gmoccapy to get what he wanted. In other words I'm invested in both and would have worked on any bugs I caused. You sometimes break little things to make things better. But yes I will probably do less work in linuxcnc and I guess I will ask for permission to work on my code. Chris ________________________________ From: David Mueller <[email protected]> Sent: September 18, 2026 1:21 AM To: [email protected] <[email protected]> Subject: Re: [Emc-developers] branch protection turned on Pushing directly may be acceptable for sections of code that only you are working on, like QTdragon, but it is not OK for sections where you collaborate with others. I've had a PR open for 3 weeks that fixes issues in gmoccapy and some gladevcp widgets it uses. Your push drove right over it, not only causing merge conflicts but actually introducing new issues. So I would VERY much appreciate it if you could file those changes that touch gladevcp and gmoccapy as a PR. Thank you David _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
