Hi Yoni,
The patch looks good. I've got just a few minor suggestions.
> EMMS is the Emacs Multi-Media System.
I prefer ``Emacs Multimedia System''. Nobody writes ``multi-media''.
> -EMMS is easy to customize by using [...]
> +EMMS is easy to customise by using [...]
It's also easy to customise by using Customize. :-)
> For the most basic needs, you will just need the following line:
>
> [...]
>
> Which installs the core of EMMS.
These broken sentences are a pet peeve of mine. Do this instead:
For the most basic needs, you will just need the following line,
...
which installs the core of EMMS.
> +The directories you gave to `emms-setup' are used by the
> +`emms-play-all' function, in case you are wondering.
I think you should always write ``the function foo''
instead of ``the foo fuction''. Right?
> -You'll ofcourse need to also have a player if you want to actually
> +You'll of-course need to also have a player if you want to actually
How about this:
Of course, you'll also need a player if you want to actually
> -You'll ofcourse need to also have a player if you want to actually
> +You'll of-course need to also have a player if you want to actually
See above comment.
By the way, for diffing prose, I think context is better than unified.
Some people may disagree, but I think it's pretty hard to read a
paragraph when it's chopped up into pieces and mixed together with a
slightly different version of itself.
Unified diffs are line-based --- and so is code --- but prose isn't.
Kind regards,
--
Daniel Brockman <[EMAIL PROTECTED]>
So really, we all have to ask ourselves:
Am I waiting for RMS to do this? --TTN.
_______________________________________________
Emms-help mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/emms-help
