On Fri, 8 Jun 2018 15:24:14 -1000 Bob Newell <[email protected]> wrote:
> I changed my Termux setup back to generic (not using 'file) and ... this > time it worked! Surely the previous problem must have been that I had > custom code which was based on an EMMS older release, and that must have > caused a malfunction; in other words, user error. Don't think such breaking changes in emacs packages are always user error, as sometimes such breakages can be avoided. In case of emms-player-mpv guess it gotta be that emms started/stopped state changes are no longer synchronous with start/stop commands, which I don't really know if maybe a misfeature. On one hand it neither blocks emacs until mpv responds nor assumes player state changes at any point (e.g. sends emms-player-started as soon as mpv binary is found, like it was before), on the other it can break existing user code and require more complex two-step handling of start/stop stuff. It might be easy to work around by doing either of "bad" things mentioned above - either blocking or just assuming mpv state without waiting for it. If anyone has strong opinion on whether it should be strictly synchronous and/or strictly compatible that way - let me know. > The upside, though, is that the new emms-mpv is obviously solid, and is > working perfectly on my Android tablet termux installation. Volume control, > seeking, etc. ... all perfect. Great. Hopefully should eat a bit less into battery that way too, as it won't need to restart whole mpv between each track in non-'file mode anymore. As you've mentioned --input-file path and volume earlier, note that behavior wrt both of these should also change: - --input-file won't be used at all, unless you add it to emms-player-mpv-parameters list. - Software volume level (if used, should be mpv default) should stay persistent until emacs restart, as mpv won't be restarted between playlist entries either, keeping all such settings. -- Mike Kazantsev // fraggod.net _______________________________________________ Emms-help mailing list [email protected] https://lists.gnu.org/mailman/listinfo/emms-help
