I checked the following

- files unpack correctly
- there is a bit of documentation (this could be improved in the future, e.g the user has to guess to use ant)
- the licenses if the distributed libs are ok
- LICENSE.txt file is included and contents are ok
- NOTICE.txt file is included and contents are ok (though the apache sections should be moved to top in the next release)
- copyright notices in source files are ok
- disclaimer is ok
- status page exists but is not up to date. I am afraid that I currently do not have the time to update that.
- the source builds
- the source code is not tagged.
- the KEYS file exists
- the md5, sha1 and asc files are correct. The format of the md5 sum files has improved, though automatic checking with --check still does not work. Butt I did not look into this in detail.
 - there are no more duplicate jars in the example

So my Vote is +1, provided that a svn tag will be set to the revision where the source was built from

As Henning has already checked the empire-db distribution, I am content with that also.

Good work !

   Thomas

P.S. I will be on vacation and offline starting rom October 4th to October 15th.

Reply via email to