Hi everybody first I want to thank Thomas a lot for his thorough review. That sounds promising and it's likely we're close now.
It appears that the difference in the jars is a result of a difference in the file META-INF\maven\org.apache.empire-db\empire-db\pom.properties The difference is in line 2 where it gives the generation timestamp: The repo version has: #Mon Sep 07 21:43:02 GMT+01:00 2009 The dist version has: #Mon Sep 07 21:59:32 GMT+01:00 2009 For the empire-db-struts2-2.0.5-incubating.jar its probably the same thing. So we have to make sure that those jars get only generated once. Francis do you think this is a problem? If you can solve that, and the issue with the examples in the maven repo then I will be happy to vote on rc6. If I can be of any further help just let me know. Rainer Thomas Fischer wrote: > RE: [VOTE] Release Apache Empire-db 2.0.5-incubating (rc5) > > I have checked the release and I have found the following issues: > - jar files in the maven2 repo and the distribution differ. No idea how > this can happen. (see below)) > - francis' signature is not in the KEYS.txt on the website. (see > below)) > > Everything else looks good, except the issues sebb found. > > If these issues are fixed, an rc will get a +1 from me > > Thomas > > I have checked the following: > > staging repo: > - empire-db > - jar contains NOTICE and LICENSE > > -empire-db-struts2 > - jar contains NOTICE and LICENSE > > -empire-db-example-advanced > - jar contains NOTICE and LICENSE > > -empire-db-example-basic > - jar contains NOTICE and LICENSE > > -empire-db-example-cxf > - jar contains NOTICE and LICENSE > > rat report looks good > > distribution: > - NOTICE, LICENSE and DISCLAIMER look good > - javadoc looks good > - sources look good > - sources build > - unit tests pass > - all required dependencies are available from central repository, > - docs (README.txt, tutorial.pdf) look good > - md5 and sha1 sums are correct > - signatures are correct, however, francis' key is not in the KEYS.txt. > This needs to be fixed. > > compare maven repo and distribution: > - empire-db-2.0.5-incubating.jar in staging repo and in zip/tgz differ > binaryly. The file size in the staging repository is 269.663 bytes, > whereas > in the sistribution, it is 269.664 bytes. > empire-db-struts2-2.0.5-incubating.jar also seems to be different, but > has > same file size. > > Regards, > > Thomas > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected]
