Here is the patch. It is clean and complete and compatible with the
existing usage of DataType.AUTOINC. No one has to change anything in
their code (correct me if I'm wrong).

The patch required minor additions to more files than I initially
expected because of the interface and abstract class depth.

https://issues.apache.org/jira/browse/EMPIREDB-71

Thanks,

McKinley

On Tue, Jan 19, 2010 at 11:15 PM, McKinley <[email protected]> wrote:
> Adding one boolean and its setter and getter and changing only 6 or
> fewer instances of lines like col.getDataType()==DataType.AUTOINC to
> col.isAutoIncrement() fixes every DataType bug or missing feature
> related to AUTOINC for free. It is 12 lines of code divided by 5
> files.

> The meta data on the patch will be bigger than the patch for the DML
> part of this change. The DDL fixes are more about adding more
> information to support currently unsupported declarations than fixing
> bugs.

Reply via email to