After comparing the files it looks like whatever options you are using for --closure are preserving some whitespace, comments and newlines that are being stripped out when I run closure compiler manually.
On Thursday, April 24, 2014 3:24:53 PM UTC-5, Alon Zakai wrote: > > If the test suite passes with that, we should add it, pull request would > be great. > > - Alon > > > > On Thu, Apr 24, 2014 at 9:26 AM, <[email protected] <javascript:>>wrote: > >> It worked by adding --language_in=ECMASCRIPT5. I'm also using >> --compilation_level >> ADVANCED_OPTIMIZATIONS with Closure Compiler. >> >> The file produced works fine but I'm getting a lot of warnings now. I >> don't see these with --closure. >> WARNING - dangerous use of the global this object >> WARNING - Suspicious code. The result of the 'bitor' operator is not >> being used >> WARNING - unreachable code >> >> >> On Thursday, April 24, 2014 12:06:42 AM UTC-5, Chad Austin wrote: >> >>> What errors do you get? >>> >>> >>> On Wed, Apr 23, 2014 at 10:03 PM, <[email protected]> wrote: >>> >>>> What compile flags are used with --closure? I want to manually run >>>> Closure Compiler on my emscripten generated javascript to combine it with >>>> another javascript file. It works with --closure but I'm getting a couple >>>> errors when I do it myself with Closure Compiler. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "emscripten-discuss" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> >>> >>> -- >>> Chad Austin >>> Technical Director, IMVU >>> http://engineering.imvu.com <http://www.imvu.com/members/Chad/> >>> http://chadaustin.me >>> >>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "emscripten-discuss" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
