To keep everyone updated, I spoke with Alon on IRC about the PRECISE_F32 case and he showed me what was going on. In short, the function tables are a little different in the two PRECISE_F32 modes.
I have submitted a pull request for the PRECISE_F32 fix. https://github.com/kripken/emscripten/pull/2327 (Alon has already merged the previous pull request.) Once PR 2327 is merged, I believe that embind should work perfectly in fastcomp. If not, please let me know! On Thu, Apr 24, 2014 at 6:20 PM, Chad Austin <[email protected]> wrote: > On Thu, Apr 24, 2014 at 1:27 PM, Alon Zakai <[email protected]> wrote: > >> There should also be 'f' alongside 'd', for float parameters. 'd' >> converted to 'i' sounds like a bug, got a testcase? >> > > Hm, I've never seen 'f' in any Emscripten signature. It seems to turn > float into 'd'. All I've ever seen is 'v', 'i', and 'd'. > > The PRECISE_F32 case is easy to reproduce in the pull request by simply > removing this skip() call: > > > https://github.com/chadaustin/emscripten/commit/9a530d0e76ea951f761d93ce3aa739b5605acb25#diff-cc4345db19ff44863e9122c74e9f383fR5658 > > >> - Alon >> >> >> >> On Thu, Apr 24, 2014 at 1:44 AM, Chad Austin <[email protected]> wrote: >> >>> To keep everyone updated, I found some time to adjust the pull request, >>> as my previous attempt relied on functionality disallowed by asm.js. >>> >>> https://github.com/kripken/emscripten/pull/2287 >>> >>> embind/asm.js passes tests and works in my little example programs. >>> >>> There is a caveat: PRECISE_F32 mode appears to change the function >>> signatures such that "d" becomes "i", which embind doesn't (currently) >>> understand. Alon, does what I'm seeing make sense to you? I'm not really >>> sure what to do about that. It seems that anything that relies on dynCall >>> would break in PRECISE_F32 mode. >>> >>> embind/asm.js requires fastcomp and will not work with the old asm.js >>> compiler. If you must use embind and the old compiler, disable asm.js. >>> >>> Hopefully, this pull request is good enough to merge and embind will be >>> a first class citizen again! >>> >>> >>> >>> On Sun, Apr 13, 2014 at 5:35 PM, Chad Austin <[email protected]> wrote: >>> >>>> Thanks, running now! >>>> >>>> >>>> On Sun, Apr 13, 2014 at 4:53 PM, Alon Zakai <[email protected]>wrote: >>>> >>>>> >>>>> >>>>> >>>>> On Sun, Apr 13, 2014 at 4:25 PM, Chad Austin <[email protected]> wrote: >>>>> >>>>>> >>>>>> Can someone remind me how to run the embind tests within the >>>>>> Emscripten test suite? >>>>>> >>>>>> >>>>> python tests/runner.py ALL.test_embind >>>>> python tests/runner.py ALL.test_embind_2 >>>>> python tests/runner.py other.test_embind >>>>> >>>>> - Alon >>>>> >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "emscripten-discuss" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> >>>> >>>> -- >>>> Chad Austin >>>> Technical Director, IMVU >>>> http://engineering.imvu.com <http://www.imvu.com/members/Chad/> >>>> http://chadaustin.me >>>> >>>> >>>> >>> >>> >>> -- >>> Chad Austin >>> Technical Director, IMVU >>> http://engineering.imvu.com <http://www.imvu.com/members/Chad/> >>> http://chadaustin.me >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "emscripten-discuss" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "emscripten-discuss" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Chad Austin > Technical Director, IMVU > http://engineering.imvu.com <http://www.imvu.com/members/Chad/> > http://chadaustin.me > > > -- Chad Austin Technical Director, IMVU http://engineering.imvu.com <http://www.imvu.com/members/Chad/> http://chadaustin.me -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
