Confirmed fixed for me; ogv.js builds on incoming again! For ogv.js, NO_FILESYSTEM=1 saves 68k of JavaScript (18k gzipped) -- that's about 7% of the codec payload for theora+vorbis+opus.
Total JS output sizes are about the same as before the new libc stuff merged, and nothing else appears to have broken yet. :) -- brion On Fri, Jul 17, 2015 at 6:09 PM, Alon Zakai <[email protected]> wrote: > Ok, that should now be fixed on incoming. > > On Thu, Jul 16, 2015 at 8:34 AM, Brion Vibber <[email protected]> wrote: > >> On Thu, Jul 16, 2015 at 9:55 AM, Floh <[email protected]> wrote: >> >>> I have the same problem, it is caused in my case by the '-s >>> NO_FILESYSTEM=1' compile option, removing this works as a workaround. >>> >> >> Bingo, disabling NO_FILESYSTEM works around the build fail for me too. >> Thanks! >> >> >>> >>> https://github.com/kripken/emscripten/issues/3627 >>> >>> It's hopefully easy to fix, I'd prefer to keep the NO_FILESYSTEM option >>> to reduce the 'binary size' a bit. >>> >> >> *nod* I don't need actual filesystem functions either but do need printf >> for debugging, error messages, etc from the libraries I use. >> >> -- brion >> >> >> >>> >>> Cheers, >>> -Floh. >>> >>> Am Donnerstag, 16. Juli 2015 14:39:57 UTC+2 schrieb Brion Vibber: >>>> >>>> My ogv.js library fails to build on incoming, reporting unresolved >>>> symbols for a few syscalls: >>>> >>>> error: unresolved symbol: __syscall6 >>>> error: unresolved symbol: __syscall54 >>>> error: unresolved symbol: __syscall140 >>>> error: unresolved symbol: __syscall146 >>>> AssertionError: Emscripten failed to generate .js >>>> >>>> -- brion vibber (brion @ pobox.com / bvibber @ wikimedia.org) >>>> >>>> On Wed, Jul 15, 2015 at 7:35 PM, Alon Zakai <[email protected]> wrote: >>>> >>>>> The incoming branch received a large update with the merge of the >>>>> musl-syscalls branch. See >>>>> >>>>> https://github.com/kripken/emscripten/issues/2701 >>>>> >>>>> for details. To summarize, >>>>> >>>>> * Emscripten now uses printf etc. from musl, replacing our old JS >>>>> code for it. The same is true for other bits of libc. This improves a >>>>> bunch >>>>> of libc bugs we have had, and makes printf etc. much faster. >>>>> * musl uses linux-style syscalls, which Emscripten implements. So >>>>> musl's printf does a syscall to actually print out characters, and >>>>> Emscripten implements that syscall. This is a smaller API than all of >>>>> libc, >>>>> and so is easier to maintain. >>>>> * This means more compiled C code, which means tiny "hello world" >>>>> programs are larger. However, optimized builds of normal-sized projects >>>>> are >>>>> often smaller (see numbers in the github issue). >>>>> >>>>> This update changes libc in significant ways, which may affect your >>>>> projects. Portable code should be fine, but e.g. we supported some glibc >>>>> extensions to printf that musl does not. See >>>>> >>>>> >>>>> https://github.com/kripken/emscripten/issues/2701#issuecomment-110906712 >>>>> >>>>> for a list of potential issues. >>>>> >>>>> Please test your codebases and report any problems. >>>>> >>>>> - Alon >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "emscripten-discuss" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "emscripten-discuss" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "emscripten-discuss" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "emscripten-discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
