1. I think the utf code (see intArrayFromString) makes it easier this way. But if there's a nice way to keep the code simple and optimize it, why not.
2. Yes, it does look like .set() would be definitely better there, patch would be great. On Tue, May 17, 2016 at 3:30 PM, Karsten Schmidt <[email protected]> wrote: > Hi all, > > just a quick question about the reasons & decision taken to implement > writeStringToMemory using a temp array (via intArrayFromString) and then > copy values to the heap only from there instead of copying directly. I feel > I maybe missing something, but if not would there be interest in a patch? > Also related, why not use HEAPU8.set(u8Array, ptr) for copying instead of > the manual loop - wouldn't the former be faster, no? > > Apologies, if this has been answered before, but I couldn't find anything > in the archives... > > Thanks, K. > > -- > You received this message because you are subscribed to the Google Groups > "emscripten-discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
