1. Yes, incoming is where new development happens. It is common to have local failures, though, for various reasons, for example some tests use optional features like closure compiler (needs Java) or crunch (needs crunch), so without installing those, it will fail. But those are a small fraction of the tests - if you see lots of failures, there might be a problem with the local install (e.g., old node.js version can cause that).
What errors do you see? 2. Yes, failures on master should not happen, definitely. Assuming those aren't due to lack of Java/crunch/etc. as just mentioned, it does suggest a local install problem, as the master branch is known to pass tests on both the bots and a dev's local machine. Not a perfect guarantee but pretty good ;) I think the python test runner has ERROR for tests that fail a check, as in "this test verifies the output is X, and it the output was Y". While FAIL is the state of tests that fail to complete due to a Python exception (e.g., due to out of memory, or the test trying to access a file that doesn't exist, etc.). On Tue, Feb 7, 2017 at 3:41 PM, Qwerty Uiop <[email protected]> wrote: > Hi, > I have a couple of questions: > 1) Which branch should I use as a base - incoming or master? On one hand, > the dev's guide instructs to use "incoming". On the other hand, it also > instructs to make sure that all tests pass before submitting a patch but > the "incoming" branch already has a lot of failing tests... > > 2) I also have some failing tests on the "master" branch. Am I right that > this shouldn't happen and if it does, it should be reported? (or, perhaps, > my build environment is broken in some way) > > Btw, the test runner reports "failures" and "errors" (e.g. "FAILED > (failures=3, errors=1)"), what's the difference between them? > > Thanks! > > -- > You received this message because you are subscribed to the Google Groups > "emscripten-discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
