Sorry for the delay, here is my PR: https://github.com/kripken/emscripten/pull/5156 Looking forward to your feedback.
Harald On Saturday, January 14, 2017 at 7:46:37 PM UTC+1, Alon Zakai wrote: > > Yeah, mentioning it in the emterpreter docs makes sense I think. PR would > be great. > > On Sat, Jan 14, 2017 at 2:18 AM, Harald Reingruber <[email protected] > <javascript:>> wrote: > >> Okay. Would it make sense to mention this behaviour somewhere in the docs? >> >> Maybe here: >> https://kripken.github.io/emscripten-site/docs/porting/emterpreter.html?highlight=emterpretify#general-usage >> and here: >> https://kripken.github.io/emscripten-site/docs/tools_reference/emcc.html#emcc-js-opts >> >> I don’t think this is a big issue, but still it can catch you by >> surprise... >> >> On 03 Jan 2017, at 19:58, Alon Zakai <[email protected] <javascript:>> >> wrote: >> >> I see. Ok, then the issue is that js opts are needed for emterpretify. In >> the debug output we show "enabling js opts for EMTERPRETIFY" if they were >> not enabled already. In other words, emterpretify forces js opts, which >> affects minification. >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "emscripten-discuss" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
