Thanks for the PR! - Alon
On Thu, Jun 6, 2019 at 6:33 PM Joshua Minter <[email protected]> wrote: > We were removing a bunch of custom changes in Emscripten and noticed that > out of all of them, 64-bit file support (in particular llseek) still isn't > supported in Emscripten, even though we aren't the only ones that want this > feature (eg. #5250 > <https://github.com/emscripten-core/emscripten/issues/5250>). So we have > upstreamed this to a PR for Emscripten at #8759 > <https://github.com/emscripten-core/emscripten/pull/8759>. > > Notably, we added an extra setting called LARGE_FILESYSTEM which when > enabled will allow for seeks larger than the 2^32 limit. Due to still using > JavaScript doubles, however, it still has a hard 2^53 limit to prevent > weird errors to do with double accuracy. No other places were found that > required changes for this support and nothing was found in the documents > specifically specifying a 32-bit limit, however a test case has been added. > > We hope that you accept these changes into the main repo :) > > -- > You received this message because you are subscribed to the Google Groups > "emscripten-discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/emscripten-discuss/d9052920-1579-490e-a2da-7f176c27c295%40googlegroups.com > <https://groups.google.com/d/msgid/emscripten-discuss/d9052920-1579-490e-a2da-7f176c27c295%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/emscripten-discuss/CAEX4NpRS9MuPAu0PWwuLbCcH338vb5ZvJ3MK%3DnD-D1KbP0OUpg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
