I'm happy to work on and submit a PR, I just have a few questions: - should I use Module['buffer'], Module['wasmMemory'] or something else? My thinking would be to use wasmMemory since its already there and partially documented. - if this is gonna be put behind a flag, should the option to provide your own Module['buffer'] also be put behind a flag (potentially the same one)? It seems odd having one behind a flag and the other not especially since Module['buffer'] isn't even very usable for WebAssembly. However, putting it behind a flag could potentially break compatibility.
On Thursday, June 20, 2019 at 11:18:56 PM UTC+10, Alon Zakai wrote: > > Yes, I think we have to receive the memory in a special way in workers in > pthreads+modularize mode. So the goal isn't to support users providing > their own memory, but to make things work at all in workers. > > If this is useful - and your use case sounds reasonable! - then we should > fix this. PR would be welcome. One thought is that perhaps this should be > behind a flag, as it will increase code size (the optimizer won't be able > to remove it statically), and we prefer to not do that. > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/emscripten-discuss/0745e923-cf28-4f89-95f0-c388e3f534e9%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
