If all the tests pass under strict mode is there any risk that something would break in non-strict mode, though? I was thinking not, so we could just run all the existing tests in strict mode only.
On Mon, Aug 19, 2019 at 1:07 PM Alon Zakai <[email protected]> wrote: > I worry about doubling our build times, and replacing seems too risky > (most people run in non-strict mode). But some amount of additional > coverage makes sense, I agree. > > On Mon, Aug 19, 2019 at 12:01 PM 'Sam Clegg' via emscripten-discuss < > [email protected]> wrote: > >> I suggest we add strict mode to our entire test suite if possible. >> >> On Mon, Aug 19, 2019 at 10:42 AM Alon Zakai <[email protected]> wrote: >> > >> > I understand, no problem. >> > >> > I have a work in progress PR for adding more comprehensive strict mode >> testing. I see there are a few existing issues, so perhaps you hit one of >> those. I hope to find time to work on this soon. >> > >> > - Alon >> > >> > >> > On Mon, Aug 19, 2019 at 5:10 AM Юрий Катков <[email protected]> wrote: >> >> >> >> Unfortunatly I can't proveide example, which reproduces such behavior >> on desktop. I received this error only on IOS 13, but I ran the same web >> page on the previous verions of IOS (with the same "strict mode" setting, >> if it was) :( >> >> >> >> and thank for your reply. >> >> >> >> On Thursday, August 15, 2019 at 11:42:21 PM UTC+3, Alon Zakai wrote: >> >>> >> >>> I don't think Safari enables strict mode by default - that would >> break a lot of sites! But maybe this is in some special specific case? Or >> maybe your app is run inside HTML or JS that enables strict mode? >> >>> >> >>> In general, we should fix strict mode bugs - please file an issue >> with a testcase, if the errors show up in emscripten-generated code. (To >> debug this, it's usually easier to look on a desktop browser in a >> non-minified build.) >> >>> >> >>> On Wed, Aug 14, 2019 at 6:48 AM Юрий Катков <[email protected]> >> wrote: >> >>>> >> >>>> Hi! >> >>>> >> >>>> I've compiled my code with emscripten 1.38.28 and now I try to >> launch it on IOS 13. I've encountered with such error in Safari browser: >> >>>> [Error] Unhandled Promise Rejection: TypeError: 'arguments', >> 'callee', and 'caller' cannot be accessed in this context. >> >>>> (anonymous function) (wasm_engine.js:1:164129) >> >>>> run (wasm_engine.js:1:164129) >> >>>> runCaller (wasm_engine.js:1:164033) >> >>>> removeRunDependency (wasm_engine.js:1:17782) >> >>>> receiveInstance (wasm_engine.js:1:19069) >> >>>> receiveInstantiatedSource (wasm_engine.js:1:19358) >> >>>> promiseReactionJob >> >>>> >> >>>> I'm not good in web development and JS in partial, but after some >> investigations I think, the problem is that Safari on IOS 13 uses strict >> mode by default, which causes error mentioned above. >> >>>> >> >>>> Could anyone suggest me how can I compile JS glue code for strict >> mode or avoid such error in my web js code? >> >>>> >> >>>> Thanks a lot! >> >>>> >> >>>> -- >> >>>> You received this message because you are subscribed to the Google >> Groups "emscripten-discuss" group. >> >>>> To unsubscribe from this group and stop receiving emails from it, >> send an email to [email protected]. >> >>>> To view this discussion on the web visit >> https://groups.google.com/d/msgid/emscripten-discuss/a4d699b6-235d-4043-b694-2a573beff35e%40googlegroups.com >> . >> >> >> >> -- >> >> You received this message because you are subscribed to the Google >> Groups "emscripten-discuss" group. >> >> To unsubscribe from this group and stop receiving emails from it, send >> an email to [email protected]. >> >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/emscripten-discuss/f818c75b-93a3-4b13-a9f1-793d4c7b6ccc%40googlegroups.com >> . >> > >> > -- >> > You received this message because you are subscribed to the Google >> Groups "emscripten-discuss" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> an email to [email protected]. >> > To view this discussion on the web visit >> https://groups.google.com/d/msgid/emscripten-discuss/CAEX4NpRgk1ZsV79FQwJZ2hNOkXJ-Fx-GP1yTnOPUGaG73TY%3DvQ%40mail.gmail.com >> . >> >> -- >> You received this message because you are subscribed to the Google Groups >> "emscripten-discuss" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/emscripten-discuss/CAL_va291UoU%2Bu9TH4gVDYR8unaVyMOL8YbnauNV0dMrBpmxCXg%40mail.gmail.com >> . >> > -- > You received this message because you are subscribed to the Google Groups > "emscripten-discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/emscripten-discuss/CAEX4NpRxV2Wn7TvZDDyOg7Bx%2BS57ishEMC6dXj%2BuQSHhnG_83g%40mail.gmail.com > <https://groups.google.com/d/msgid/emscripten-discuss/CAEX4NpRxV2Wn7TvZDDyOg7Bx%2BS57ishEMC6dXj%2BuQSHhnG_83g%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/emscripten-discuss/CAJZD_EX4NRGyvJc%3DL%3D2gqXQU7zgLFSnxoa3JbVUb-V%2BKJyhqjQ%40mail.gmail.com.
