Thank you for the details, the PR is not about the test I sent thought. To answer your question, in Chromium the test makes the page hang. I cannot get anything on the console unfortunately.
If I add -s PROXY_TO_PTHREAD=1 (without OFFSCREEN_FRAMEBUFFER as stated in the test) I get : pthread_create: failed to transfer control of canvas "canvas" to OffscreenCanvas! Error: ReferenceError: document is not defined for gl_in_pthread.cpp: - if I don't use -s PROXY_TO_PTHREAD=1, the page hangs - if I don't use -s OFFSCREEN_FRAMEBUFFER=1 I get the error above On Tuesday, August 27, 2019 at 1:02:34 AM UTC+2, Alon Zakai wrote: > > I just refactored that test a little in > > https://github.com/emscripten-core/emscripten/pull/9293 > > The flags used in the test now in test_browser.py should only be actually > necessary ones. > > You do need either OffscreenCanvas support, or OFFSCREEN_FRAMEBUFFER. > OffscreenCanvas is a browser API, which works in at least Chrome, while > OFFSCREEN_FRAMEBUFFER compiles in some code to proxy GL commands to the > main thread, so it's like a polyfill for OffscreenCanvas. > > Note that you currently need to set OFFSCREENCANVAS_SUPPORT even if using > FRAMEBUFFER. I'm not sure why that is, but I think it's why your command > didn't work. If that's not it, is an error shown in the dev console perhaps? > > > On Mon, Aug 26, 2019 at 9:52 AM Mehdi Sabwat <mehdi...@gmail.com > <javascript:>> wrote: > >> Hi, >> >> The test >> <https://github.com/emscripten-core/emscripten/blob/incoming/tests/gl_in_pthread.cpp> >> >> with these command options >> <https://github.com/emscripten-core/emscripten/blob/736565ee2827280c3f69126b1151e7b8fb3f947e/tests/test_browser.py#L4020> >> >> fails in Chromium (page hanging after first pthread_create). >> >> em++ gl.cpp -o test.html -s USE_PTHREADS=1 -s PROXY_TO_PTHREAD=1 -s >> PTHREAD_POOL_SIZE=2 -s -s OFFSCREEN_FRAMEBUFFER=1 -lGL -s >> DISABLE_DEPRECATED_FIND_EVENT_TARGET_BEHAVIOR=1 --emrun >> >> I tried this instead and it seems to work better, is this the new way to >> do `-s OFFSCREENCANVAS_SUPPORT=1` ? Should this be applied to all >> gl/pthread tests? >> >> -- >> You received this message because you are subscribed to the Google Groups >> "emscripten-discuss" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to emscripten-discuss+unsubscr...@googlegroups.com <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/emscripten-discuss/06462979-cf0b-4bd8-912d-1957f5d6b1ad%40googlegroups.com >> >> <https://groups.google.com/d/msgid/emscripten-discuss/06462979-cf0b-4bd8-912d-1957f5d6b1ad%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-discuss+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/emscripten-discuss/f58a7e32-fe5a-41eb-bf3e-a694354d785c%40googlegroups.com.
