On Wed, Oct 2, 2019 at 12:35 PM Beuc <[email protected]> wrote: > > I just upgraded 1.38.45->1.38.46 and I got a new build failure in an > unmodified ffmpeg build. > Which is also what happened last time I upgraded Emscripten 1 month ago > (different error). > I don't see wasm-ld-related notes in the ChangeLog, but apparently it got > stricter again. > Compiling a few external libs may actually be a good release test case for > the Emscripten project ¯\_(ツ)_/¯ >
I think are you referring to this bug https://github.com/emscripten-core/emscripten/issues/9565? The good news is that we now have a unit test to cover that specific issue. But I agree we also need larger system tests. Perhaps we could add ffmpeg to our build somehow, perhaps via an improved ports system. > - Beuc > > On 20/09/2019 20:06, Beuc wrote: > > Hi, > > On 17/09/2019 00:18, Alon Zakai wrote: > > On Mon, Sep 16, 2019 at 6:50 AM Beuc <[email protected]> wrote: >> >> > * Are there tests in your codebase that we could run in upstream >> > emscripten? >> >> Come to think of it, there's one thorough automated test that we have to run >> at each upgrade: >> building dependencies! >> [...] > > It might be useful to set up CI that runs the emscripten tip-of-tree builds > on that (emsdk install tot-fastcomp or tot-upstream). Those are literally the > very newest code, that passed chromium CI but is not as heavily tested as the > actual release tags. You may sometimes see a temporary breakage you can > ignore, but it would also catch regressions. > > There seem to be a misunderstanding, you asked for test you could run, not > the other way around ;) > > It isn't worth it for us to constantly rebuild with ToT: most of the time > we're working on Ren'Py/RenPyWeb itself and can't afford varying dependencies. > Investigating all temporary and non-temporary breakages sounds like time I > should reserve for properly upgrading and adapting to a newer, stable > Emscripten once every other month. > > - Tagging: TBH I didn't figure out yet e.g. "what LLVM commit is used for > emsdk 1.38.42" from https://chromium.googlesource.com/emscripten-releases/ > > > Is that still an issue? Are the docs at > > https://github.com/emscripten-core/emscripten/blob/incoming/docs/process.md#packaging-emscripten > > (I hadn't seen this question on first read.) > > My first attempts with binaryen seems to work, and for those interested Sam > Clegg posted a recap: > > https://github.com/emscripten-core/emscripten/issues/8995#issuecomment-532984238 > > -- > You received this message because you are subscribed to the Google Groups > "emscripten-discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/emscripten-discuss/3f1f8c14-8d50-d66d-f6fb-31c588f42acf%40beuc.net. -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/emscripten-discuss/CAL_va29dxeiMwU8mO%2BKTHbp383tCp6vzMTt%3D9oCd8H2Te%3DS7UQ%40mail.gmail.com.
