Shot in the dark, but the only place where I can find BINARYEN_ROOT in emsdk in in this manifest file:
https://github.com/emscripten-core/emsdk/blob/master/emsdk_manifest.json ...and in the commit which moved incoming to master some references to binaryen had been removed: https://github.com/emscripten-core/emsdk/commit/3631f0aac338f38eb11d4396f7f307fb0148d2d4#diff-a1b4faa6091de6a8facd6ea8c3ffabd4L605 ...and maybe the BINARYEN_ROOT entry in the .emscripten file was provided by those removed references? Hacking around in that manifest file and running emsdk activate again didn't change anything though, so maybe it's not that, but something else in that commit might be the corpus delicti :) I'll tinker around a bit more and try to write a proper emsdk issue later :) -Floh. On Wednesday, 29 January 2020 13:00:32 UTC+1, Floh wrote: > > I'll try to investigate a bit and then write a bug report. One difference > to a "default install" on my side is that I'm activating the SDK with the > --embedded option. > > On Tuesday, 28 January 2020 21:58:01 UTC+1, Alon Zakai wrote: >> >> Sounds like a bug, yeah, BINARYEN_ROOT should be written, please file an >> issue. >> >> Btw, instead of "sdk-upstream-master-64bit" you can install "tot" which >> is the latest tip of tree build - that's a nice way to get prebuilt >> binaries of very new code (the very last thing that passed CI). >> >> >> On Tue, Jan 28, 2020 at 5:29 AM Floh <[email protected]> wrote: >> >>> Hi, just wanted to switch over to the master (FKA incoming) version to >>> check out the new WebGPU stuff, and I'm getting an error trying to compile: >>> >>> shared:ERROR: BINARYEN_ROOT is not defined in >>> /Users/floh/projects/fips-sdks/emsdk/.emscripten >>> >>> When activating the "sdk-upstream-master-64bit" SDK version I can see >>> that BINARYEN_ROOT is indeed not written: >>> >>> The Emscripten configuration file >>> /Users/floh/projects/fips-sdks/emsdk/.emscripten has been rewritten with >>> the following contents: >>> >>> import os >>> emsdk_path=os.path.dirname(os.environ.get('EM_CONFIG')).replace('\\', >>> '/') >>> LLVM_ROOT = '' + emsdk_path + '/llvm/git/build_master_64/bin' >>> NODE_JS = '' + emsdk_path + '/node/12.9.1_64bit/bin/node' >>> EMSCRIPTEN_ROOT = '' + emsdk_path + '/emscripten/master' >>> EMSCRIPTEN_NATIVE_OPTIMIZER = '' + emsdk_path + >>> '/emscripten/master_64bit_optimizer/optimizer' >>> TEMP_DIR = '' + emsdk_path + '/tmp' >>> COMPILER_ENGINE = NODE_JS >>> JS_ENGINES = [NODE_JS] >>> >>> When switching to "latest" it's there: >>> >>> The Emscripten configuration file >>> /Users/floh/projects/fips-sdks/emsdk/.emscripten has been rewritten with >>> the following contents: >>> >>> import os >>> emsdk_path=os.path.dirname(os.environ.get('EM_CONFIG')).replace('\\', >>> '/') >>> NODE_JS = '' + emsdk_path + '/node/12.9.1_64bit/bin/node' >>> LLVM_ROOT = '' + emsdk_path + '/upstream/bin' >>> BINARYEN_ROOT = '' + emsdk_path + '/upstream' >>> EMSCRIPTEN_ROOT = '' + emsdk_path + '/upstream/emscripten' >>> TEMP_DIR = '' + emsdk_path + '/tmp' >>> COMPILER_ENGINE = NODE_JS >>> JS_ENGINES = [NODE_JS] >>> >>> Is this a known issue, or should I write a ticket in the emsdk github >>> repo? (a casual search didn't find and existing bug there) >>> >>> Cheers, >>> -Floh. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "emscripten-discuss" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/emscripten-discuss/196ba734-220d-4282-a9ef-d0dd9ed5a476%40googlegroups.com >>> >>> <https://groups.google.com/d/msgid/emscripten-discuss/196ba734-220d-4282-a9ef-d0dd9ed5a476%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/emscripten-discuss/b2caa583-0ee3-47d6-92ab-89c9ac742b00%40googlegroups.com.
