I agree with Alon, even though it's not "good practice" to have 
include/emscripten in the search path, the problems that result from such a 
name collision might be too confusing because nothing points to the file 
include/emscripten/math.h being the problem (also the function in 
emscripten/math.h are prefixed with emscripten_math_xxx(), so em_math.h 
would make more sense to me than math.h

Cheers,
-Floh.

On Thursday, 18 June 2020 18:32:30 UTC+2, Sam Clegg wrote:
>
>
>
> On Thu, Jun 18, 2020 at 8:49 AM Alon Zakai <[email protected] 
> <javascript:>> wrote:
>
>> Perhaps we should rename emscripten/math.h to emscripten/em_math.h, or 
>> something else? It seems risky to leave as it is.
>>
>
> I mean it would also fix the issue... but its also a good way to ensure we 
> are all the same page about our include paths :)
>  
>
>>
>> On Thu, Jun 18, 2020 at 7:33 AM Brian Gavin <[email protected] 
>> <javascript:>> wrote:
>>
>>> I was using 'system/include/emscripten' as an include path so I removed 
>>> it, but I am still seeing the same errors.
>>>
>>> Brian Gavin
>>>
>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "emscripten-discuss" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to [email protected] 
>>> <javascript:>.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/emscripten-discuss/2930fc46-a938-4f17-801b-597a00e74dd8o%40googlegroups.com
>>>  
>>> <https://groups.google.com/d/msgid/emscripten-discuss/2930fc46-a938-4f17-801b-597a00e74dd8o%40googlegroups.com?utm_medium=email&utm_source=footer>
>>> .
>>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "emscripten-discuss" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to [email protected] <javascript:>.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/emscripten-discuss/CAEX4NpQFarHurwkA0%3DbmPRO%2BmBPyBU4UiTRXX3g8ndhD2iDThw%40mail.gmail.com
>>  
>> <https://groups.google.com/d/msgid/emscripten-discuss/CAEX4NpQFarHurwkA0%3DbmPRO%2BmBPyBU4UiTRXX3g8ndhD2iDThw%40mail.gmail.com?utm_medium=email&utm_source=footer>
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"emscripten-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/emscripten-discuss/0de39a27-606b-4d4b-bb3d-90641e62cd05o%40googlegroups.com.

Reply via email to