On Thu, Jun 17, 2021 at 9:55 AM Alan DeKok <[email protected]> wrote:
> On Jun 17, 2021, at 12:04 PM, John Mattsson <[email protected]> > wrote: > > I have made a single PR addressing all the currently listed issues in > the way suggested by Joe. > > > > https://github.com/emu-wg/draft-ietf-emu-eap-tls13/pull/83/files > > > > - Does PR #83 address the currently listed issues? > > I'll have to go through it and see. It's normally traditional to > respond to reviews. And, to reply with proposed text for the document > update. That process allows reviewers to quickly see if their issues have > been addressed. > > The current use of GitHub makes this process rather more opaque. There > are changes to the document pushed as commits, but it requires rooting > through multiple commits and references in order to see which commit > addresses which issue. The many commits of "updated document" make it more > difficult to see what is changed, and why. > > [Joe] The github PRs make it easier to view the changes in the context of the document. I realize there may be a little bit of extra work to associate the changes to the issues, but this should be too difficult to do. > > - Are there any other remaining issues that are not listed on GitHub? > > My review of a few days ago had extensive comments. It may be worth > going through that and addressing each issue. Some of the items have been > addressed, which is positive. However, it looks like all of my comments > for Section 5 remain unaddressed. > > [Joe] I opened issue 84 ( https://github.com/emu-wg/draft-ietf-emu-eap-tls13/issues/84) to track this. I think most of the section 5 issues have been addressed or can be addressed with simple changes. It's not clear what you wanted to address in section 5.3. > Alan DeKok. > >
_______________________________________________ Emu mailing list [email protected] https://www.ietf.org/mailman/listinfo/emu
